[webkit-reviews] review granted: [Bug 216484] Date/time inputs should not use user-specified formats : [Attachment 409138] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 216484: Date/time inputs should not use user-specified formats
https://bugs.webkit.org/show_bug.cgi?id=216484

Attachment 409138: Patch

https://bugs.webkit.org/attachment.cgi?id=409138&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 409138
  --> https://bugs.webkit.org/attachment.cgi?id=409138
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409138&action=review

> Tools/TestWebKitAPI/Tests/mac/DateInputTests.mm:59
> +    system([NSString stringWithFormat:@"defaults write %@ %@ -dict-add %@
%@", domain, preferencesKey, @"1", customDateFormat].UTF8String);

Nit - is there a more elegant way to do this using NSUserDefaults?

> Tools/TestWebKitAPI/Tests/mac/DateInputTests.mm:67
> +    system([NSString stringWithFormat:@"defaults delete %@ %@", domain,
preferencesKey].UTF8String);

(Ditto)