[webkit-reviews] review granted: [Bug 216669] DFG should ensure there are PhantomLocals for the taken block of op_jneq_ptr : [Attachment 409079] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 216669: DFG should ensure there are PhantomLocals for the taken block of
op_jneq_ptr
https://bugs.webkit.org/show_bug.cgi?id=216669

Attachment 409079: Patch

https://bugs.webkit.org/attachment.cgi?id=409079&action=review




--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 409079
  --> https://bugs.webkit.org/attachment.cgi?id=409079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409079&action=review

>>> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:7175
>>> +		 auto addPhantomLocalDirect = [&] (InlineCallFrame*, Operand
operand) { phantomLocalDirect(operand); };
>>> +		
flushForTerminalImpl(CodeOrigin(BytecodeIndex(m_currentIndex.offset() +
relativeOffset), inlineCallFrame()), addFlushDirect, addPhantomLocalDirect);
>> 
>> why not the current code origin?
> 
> Because the set of live locals at the target is a subset of the locals live
here. There's no point in Phantoming things that we don't need to.

let's add the comment on why we flushForTerminal here, since we don't know if
the target would've ended up doing it