[webkit-reviews] review granted: [Bug 216678] [LFC][IFC] Move inline box constructing and alignment logic to LineBoxBuilder : [Attachment 409099] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 216678: [LFC][IFC] Move inline box constructing and alignment logic to
LineBoxBuilder
https://bugs.webkit.org/show_bug.cgi?id=216678

Attachment 409099: Patch

https://bugs.webkit.org/attachment.cgi?id=409099&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 409099
  --> https://bugs.webkit.org/attachment.cgi?id=409099
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409099&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:52
> +    const Box& root() const { return formattingContext().root(); }

or rootBox()?

> Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:59
> +struct HangingContent {

It's not clear to me what "hanging" is in this context.