[webkit-reviews] review granted: [Bug 216325] Make Selection throw same errors as other browsers and return same Range object from getRangeAt like other browsers : [Attachment 409003] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 216325: Make Selection throw same errors as other browsers and return same
Range object from getRangeAt like other browsers
https://bugs.webkit.org/show_bug.cgi?id=216325

Attachment 409003: Patch

https://bugs.webkit.org/attachment.cgi?id=409003&action=review




--- Comment #38 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 409003
  --> https://bugs.webkit.org/attachment.cgi?id=409003
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409003&action=review

> Source/WebCore/ChangeLog:7
> +

I think this could use a brief explanation/overview of the changes, especially
why a setting is being added.

> Source/WebCore/editing/FrameSelection.cpp:2783
> +static bool isRootNode(Document* document, const Optional<SimpleRange>&
range)

This name is confusing to me. It seems like it should include the word contains
somewhere.

> LayoutTests/ChangeLog:7
> +

What's the plan for tests here? I assume this should start passing a bunch of
the WPT suite with LiveRangeSelectionEnabled turned on, no?