[webkit-reviews] review denied: [Bug 216639] [CMake] Replace CMAKE_BINARY_DIR and CMAKE_SOURCE_DIR with PROJECT_BINARY_DIR and PROJECT_SOURCE_DIR : [Attachment 409000] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 17 12:50:35 PDT 2020
Don Olmstead <don.olmstead at sony.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 216639: [CMake] Replace CMAKE_BINARY_DIR and CMAKE_SOURCE_DIR with
PROJECT_BINARY_DIR and PROJECT_SOURCE_DIR
https://bugs.webkit.org/show_bug.cgi?id=216639
Attachment 409000: Patch
https://bugs.webkit.org/attachment.cgi?id=409000&action=review
--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 409000
--> https://bugs.webkit.org/attachment.cgi?id=409000
Patch
I really think any project trying to use WebKit like this should be using
https://cmake.org/cmake/help/latest/module/ExternalProject.html
More information about the webkit-reviews
mailing list