[webkit-reviews] review denied: [Bug 215829] [ iOS Release ] imported/w3c/web-platform-tests/* is flaky failing 200+ tests : [Attachment 408936] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 17 12:47:23 PDT 2020


Aakash Jain <aakash_jain at apple.com> has denied Sam Sneddon [:gsnedders]
<gsnedders at apple.com>'s request for review:
Bug 215829: [ iOS Release ] imported/w3c/web-platform-tests/* is flaky failing
200+ tests
https://bugs.webkit.org/show_bug.cgi?id=215829

Attachment 408936: Patch

https://bugs.webkit.org/attachment.cgi?id=408936&action=review




--- Comment #25 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 408936
  --> https://bugs.webkit.org/attachment.cgi?id=408936
Patch

Breaks layout-tests

e.g.: https://ews-build.webkit.org/#/builders/30/builds/18734

From
/Volumes/Data/worker/macOS-Mojave-Release-WK1-Tests-EWS/build/layout-test-resul
ts/wptwk_process_log.out.txt on ews101:

WARNING:web-platform-tests:Status of subprocess "http on port 8801": failed.
Exit with non-zero status: 1
INFO:web-platform-tests:Status of subprocess "https on port 9443": running
    self.run()
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multipr
ocessing/process.py", line 114, in run 
    self._target(*self._args, **self._kwargs)
  File
"/Volumes/Data/worker/macOS-Mojave-Release-WK1-Tests-EWS/build/LayoutTests/impo
rted/w3c/web-platform-tests/tools/serve/serve.py", line 422, in create_daemon
    resource.setrlimit(resource.RLIMIT_NOFILE, (nofile_hard, nofile_hard))
ValueError: current limit exceeds maximum limit
Process https on port 9443:
Traceback (most recent call last):
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multipr
ocessing/process.py", line 258, in _bootstrap
    self.run()
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multipr
ocessing/process.py", line 114, in run 
    self._target(*self._args, **self._kwargs)
  File
"/Volumes/Data/worker/macOS-Mojave-Release-WK1-Tests-EWS/build/LayoutTests/impo
rted/w3c/web-platform-tests/tools/serve/serve.py", line 422, in create_daemon
    resource.setrlimit(resource.RLIMIT_NOFILE, (nofile_hard, nofile_hard))
ValueError: current limit exceeds maximum limit


More information about the webkit-reviews mailing list