[webkit-reviews] review granted: [Bug 216266] XHR.timeout is affected by long tasks : [Attachment 408918] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 17 11:14:44 PDT 2020

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 216266: XHR.timeout is affected by long tasks

Attachment 408918: Patch


--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 408918
  --> https://bugs.webkit.org/attachment.cgi?id=408918

View in context: https://bugs.webkit.org/attachment.cgi?id=408918&action=review

> Source/WebCore/loader/ThreadableLoader.h:79
> +	   virtual void computeIsDone() = 0;

I think it would be much better to have a CompletionHandler<void(bool)>&& here
than introduce a new function on the client that this will call as a callback.

> Source/WebCore/loader/WorkerThreadableLoader.h:63
> +	   void notifyIsDone(bool isDone);


More information about the webkit-reviews mailing list