[webkit-reviews] review granted: [Bug 216654] Remove AnimationTimeline::animationsForElement() and the CSS Transitions and CSS Animations accessors on ElementAnimationRareData : [Attachment 409049] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 216654: Remove AnimationTimeline::animationsForElement() and the CSS
Transitions and CSS Animations accessors on ElementAnimationRareData
https://bugs.webkit.org/show_bug.cgi?id=216654

Attachment 409049: Patch

https://bugs.webkit.org/attachment.cgi?id=409049&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 409049
  --> https://bugs.webkit.org/attachment.cgi?id=409049
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409049&action=review

> Source/WebCore/animation/DocumentTimeline.cpp:338
> +    if (auto* animations = renderer.element()->animations()) {

Early return if renderer.element()->animations() is null?

> Source/WebCore/animation/DocumentTimeline.cpp:360
> +    if (auto* animations = renderer.element()->animations()) {

Early return if renderer.element()->animations() is null?

> Source/WebCore/animation/DocumentTimeline.cpp:379
> +    if (auto* animations = renderer.element()->animations()) {

Early return if renderer.element()->animations() is null?

> Source/WebCore/animation/DocumentTimeline.cpp:401
> +	   if (auto* animations = renderer.element()->animations()) {

Early return if element or renderer.element()->animations() are null?