[webkit-reviews] review denied: [Bug 216604] [GTK][WPE] Missing support for multi-word $WEBKIT_MINI_BROWSER_PREFIX : [Attachment 408904] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 216604: [GTK][WPE] Missing support for multi-word
$WEBKIT_MINI_BROWSER_PREFIX
https://bugs.webkit.org/show_bug.cgi?id=216604

Attachment 408904: Patch

https://bugs.webkit.org/attachment.cgi?id=408904&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 408904
  --> https://bugs.webkit.org/attachment.cgi?id=408904
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408904&action=review

> Tools/Scripts/webkitpy/port/gtk.py:272
> +	       command = os.environ["WEBKIT_MINI_BROWSER_PREFIX"].split() +
command

Is there any reason to not use shlex.split() here? That would allow for
specifying parameters in the environment variable which have themselves
spaces, by carefully quoting things around. For example:

  WEBKIT_MINI_BROWSER_PREFIX="'/opt/dev tools v1/bin/gdb' --args" \
       run-minibrowser […]

Using a plain str.split() would completely prevent such usage. Not that
I expect quoting of parameters inside the environment variable to be
needed often, but it does not hurt to have our backs covered :)