[webkit-reviews] review granted: [Bug 216624] WKPageLoadURLRequestReturningNavigation should allow opening universal links : [Attachment 408994] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Hoa Dinh <dvh at apple.com>'s request
for review:
Bug 216624: WKPageLoadURLRequestReturningNavigation should allow opening
universal links
https://bugs.webkit.org/show_bug.cgi?id=216624

Attachment 408994: Patch

https://bugs.webkit.org/attachment.cgi?id=408994&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 408994
  --> https://bugs.webkit.org/attachment.cgi?id=408994
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408994&action=review

> Source/WebKit/ChangeLog:24
> +	   * UIProcess/API/C/mac/WKPagePrivateMac.mm:
> +	   (WKPageLoadURLRequestReturningNavigation): Allow universal links.

What’s the rationale for this? I’m not sure there’s anything in the name that
makes it clear it should allow universal links. I presume this is the behavior
Safari wants, but is that clear enough in the SPI contract for this function?
Are there non-Safari clients who might want different behavior?