[webkit-reviews] review granted: [Bug 216637] [JSC] Optimize Promise#finally by avoiding creating multiple environments : [Attachment 408992] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 216637: [JSC] Optimize Promise#finally by avoiding creating multiple
environments
https://bugs.webkit.org/show_bug.cgi?id=216637

Attachment 408992: Patch

https://bugs.webkit.org/attachment.cgi?id=408992&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 408992
  --> https://bugs.webkit.org/attachment.cgi?id=408992
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408992&action=review

Seems fine to me.

> Source/JavaScriptCore/builtins/PromisePrototype.js:74
> +	   thenFinally = (0, /* prevent function name inference */ (value) => {

nit: Seems like this could be a line comment above? But I don't feel that
strongly.