[webkit-reviews] review granted: [Bug 216623] AudioBufferSourceNode.start() ignores 'when' parameter when pitch rate is 0 : [Attachment 408960] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 16 16:23:39 PDT 2020


Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 216623: AudioBufferSourceNode.start() ignores 'when' parameter when pitch
rate is 0
https://bugs.webkit.org/show_bug.cgi?id=216623

Attachment 408960: Patch

https://bugs.webkit.org/attachment.cgi?id=408960&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 408960
  --> https://bugs.webkit.org/attachment.cgi?id=408960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408960&action=review

> Source/WebCore/ChangeLog:10
> +	   begining out the destination buffer, ignoring the computed
writeIndex. As a result,

s/out/of/


More information about the webkit-reviews mailing list