[webkit-reviews] review granted: [Bug 213899] [Flatpak SDK][WPE] Launching the remote inspector kills MB : [Attachment 403766] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 16 13:55:28 PDT 2020

Adrian Perez <aperez at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 213899: [Flatpak SDK][WPE] Launching the remote inspector kills MB

Attachment 403766: Patch


--- Comment #6 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 403766
  --> https://bugs.webkit.org/attachment.cgi?id=403766

View in context: https://bugs.webkit.org/attachment.cgi?id=403766&action=review

>> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp:49
>> +	    const char* path = g_getenv("WEBKIT_INJECTED_BUNDLE_PATH");
> I was lazy here. I can a new variable if the reviewer kindly asks :)

As this is going to be used only for developer builds, I think it is okay
to reuse this variable that is already being set by all our scripts instead
of introducing a new one which would need handling in many places.

More information about the webkit-reviews mailing list