[webkit-reviews] review granted: [Bug 216562] Remove runtime setting for enabling/disabling the isSecureContext API? : [Attachment 408942] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 16 12:33:47 PDT 2020


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 216562: Remove runtime setting for enabling/disabling the isSecureContext
API?
https://bugs.webkit.org/show_bug.cgi?id=216562

Attachment 408942: Patch

https://bugs.webkit.org/attachment.cgi?id=408942&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 408942
  --> https://bugs.webkit.org/attachment.cgi?id=408942
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408942&action=review

r=me assuming tests pass

> Source/WebCore/page/WindowOrWorkerGlobalScope.idl:64
> +    // microtask queuing.

Capitalize microtask if we are using sentence style? Also, why does a single
function "queue microtask" need a comment saying "microtask queuing"? I’m not
sure of the value of these section comments.


More information about the webkit-reviews mailing list