[webkit-reviews] review granted: [Bug 216465] [CMake] Add TestRunnerShared library target : [Attachment 408899] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 216465: [CMake] Add TestRunnerShared library target
https://bugs.webkit.org/show_bug.cgi?id=216465

Attachment 408899: Patch

https://bugs.webkit.org/attachment.cgi?id=408899&action=review




--- Comment #7 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 408899
  --> https://bugs.webkit.org/attachment.cgi?id=408899
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408899&action=review

r=me with nits

> Source/cmake/WebKitFS.cmake:54
> +set(TestRunnerShared_DERIVED_SOURCES_DIR
"${CMAKE_BINARY_DIR}/DerivedSources/TestRunnerShared")

For WinCairo can you override this according to the directory structure there?

> Tools/DumpRenderTree/CMakeLists.txt:23
> +    TestRunnerShared

Any reason you're not using WebKit::TestRunnerShared? You declared it by doing
WEBKIT_FRAMEWORK.