[webkit-reviews] review granted: [Bug 216576] Merge PeriodicWave improvements from Blink : [Attachment 408926] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 216576: Merge PeriodicWave improvements from Blink
https://bugs.webkit.org/show_bug.cgi?id=216576

Attachment 408926: Patch

https://bugs.webkit.org/attachment.cgi?id=408926&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 408926
  --> https://bugs.webkit.org/attachment.cgi?id=408926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408926&action=review

> Source/WebCore/Modules/webaudio/PeriodicWave.cpp:47
> +// The number of bands per octave. Each octave will have this many entries
in the wave tables.
> +const unsigned NumberOfOctaveBands = 3;
> +
> +// The max length of a periodic wave. This must be a power of two greater
than
> +// or equal to 2048 and must be supported by the FFT routines.
> +const unsigned MaxPeriodicWaveSize = 16384;
> +
> +const float CentsPerRange = 1200 / NumberOfOctaveBands;

constexpr unless we want to leave this alone so it’s easier to merge from
Chromium