[webkit-reviews] review granted: [Bug 216593] [macOS] Limit reported macOS release to 10.15 series : [Attachment 408883] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 216593: [macOS] Limit reported macOS release to 10.15 series
https://bugs.webkit.org/show_bug.cgi?id=216593

Attachment 408883: Patch

https://bugs.webkit.org/attachment.cgi?id=408883&action=review




--- Comment #4 from Maciej Stachowiak <mjs at apple.com> ---
Comment on attachment 408883
  --> https://bugs.webkit.org/attachment.cgi?id=408883
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408883&action=review

r=me

>> Source/WebCore/platform/mac/UserAgentMac.mm:39
>> +	    osVersion = "10_15_6"_s;
> 
> Why do it this roundabout way instead of hardcoding this to "10_15_6"_s
always? Under what circumstances would osVersion not start with 10? And if we
fully hardcoded it, maybe we could encode it directly in the template string,
same as the AppleWebKit/ version number.

Oh, I understand now. This is to preserve original OS version on older macOS.