[webkit-reviews] review granted: [Bug 182845] [Cocoa] Use OTF font features instead of AAT font features when possible : [Attachment 408888] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 182845: [Cocoa] Use OTF font features instead of AAT font features when
possible
https://bugs.webkit.org/show_bug.cgi?id=182845

Attachment 408888: Patch

https://bugs.webkit.org/attachment.cgi?id=408888&action=review




--- Comment #12 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 408888
  --> https://bugs.webkit.org/attachment.cgi?id=408888
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408888&action=review

Very good!

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-506
> -	       case kCTFontTableGPOS:
> -	       case kCTFontTableGSUB:
> -		   openTypeShaping = true;
> -		   break;

I think we should keep this. I expect we'll need this for other things.

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-522
> -    bool openTypeShaping { false };

Ditto.