[webkit-reviews] review denied: [Bug 216536] Add further temporary debug logging for wptserve : [Attachment 408838] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 15 14:27:07 PDT 2020

Aakash Jain <aakash_jain at apple.com> has denied Sam Sneddon [:gsnedders]
<gsnedders at apple.com>'s request for review:
Bug 216536: Add further temporary debug logging for wptserve

Attachment 408838: Patch


--- Comment #10 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 408838
  --> https://bugs.webkit.org/attachment.cgi?id=408838

View in context: https://bugs.webkit.org/attachment.cgi?id=408838&action=review

> +		   self.logger.debug(subprocess.check_output(["ps", "aux"]))

This ('ps aux' and 'lsof -P +c0') will produce huge amount of output (tens of
thousands of lines). Are you sure you want to add that much output in the logs?
Maybe you just need a count of number of lines of these.

Also, when the machine is already running out of file handles, these commands
might just slow down/hang the machine further. This might explain why
hanged with this patch.

More information about the webkit-reviews mailing list