[webkit-reviews] review granted: [Bug 216514] [macOS] Date pickers should respect the document's color scheme : [Attachment 408774] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 216514: [macOS] Date pickers should respect the document's color scheme
https://bugs.webkit.org/show_bug.cgi?id=216514

Attachment 408774: Patch

https://bugs.webkit.org/attachment.cgi?id=408774&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 408774
  --> https://bugs.webkit.org/attachment.cgi?id=408774
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408774&action=review

>> Source/WebKit/UIProcess/mac/WebDateTimePickerMac.mm:221
>> +	[_enclosingWindow setAppearance:[NSAppearance
appearanceNamed:_params.useDarkAppearance ? NSAppearanceNameDarkAqua :
NSAppearanceNameAqua]];
> 
> This is interesting! I feel like content that pops out of the page (like,
say, context menus) usually follows the app, not the page. But probably this
makes sense?

You can just leave it implicit, too. No reason to ASSERT() something that we
expect will never happen and which will result in a crash in release, IMO.