[webkit-reviews] review granted: [Bug 216514] [macOS] Date pickers should respect the document's color scheme : [Attachment 408774] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 15 14:11:06 PDT 2020

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 216514: [macOS] Date pickers should respect the document's color scheme

Attachment 408774: Patch


--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 408774
  --> https://bugs.webkit.org/attachment.cgi?id=408774

View in context: https://bugs.webkit.org/attachment.cgi?id=408774&action=review

>> Source/WebKit/UIProcess/mac/WebDateTimePickerMac.mm:221
>> +	[_enclosingWindow setAppearance:[NSAppearance
appearanceNamed:_params.useDarkAppearance ? NSAppearanceNameDarkAqua :
> This is interesting! I feel like content that pops out of the page (like,
say, context menus) usually follows the app, not the page. But probably this
makes sense?

You can just leave it implicit, too. No reason to ASSERT() something that we
expect will never happen and which will result in a crash in release, IMO.

More information about the webkit-reviews mailing list