[webkit-reviews] review granted: [Bug 216529] [JSC] Intl.Collator should take collation option : [Attachment 408797] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 216529: [JSC] Intl.Collator should take collation option
https://bugs.webkit.org/show_bug.cgi?id=216529

Attachment 408797: Patch

https://bugs.webkit.org/attachment.cgi?id=408797&action=review




--- Comment #3 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 408797
  --> https://bugs.webkit.org/attachment.cgi?id=408797
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408797&action=review

r=me

> Source/JavaScriptCore/runtime/IntlCollator.cpp:185
> +		   throwRangeError(globalObject, scope, "collation must be
unicode-locale-identifier's \"type\""_s);

Hmm, we shouldn't require the user to know Unicode spec productions. ��
To match what we've done in other Intl classes, I would suggest "collation is
not a well-formed collation value".