[webkit-reviews] review denied: [Bug 216537] [cmake][armv7] OFFLINE_ASM_BACKEND is wrongly set building in a native ARMv7 env in the top of a ARM64 host : [Attachment 408817] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 216537: [cmake][armv7] OFFLINE_ASM_BACKEND is wrongly set building in a
native ARMv7 env in the top of a ARM64 host
https://bugs.webkit.org/show_bug.cgi?id=216537

Attachment 408817: patch

https://bugs.webkit.org/attachment.cgi?id=408817&action=review




--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 408817
  --> https://bugs.webkit.org/attachment.cgi?id=408817
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408817&action=review

r- for now

>> Source/cmake/OptionsCommon.cmake:23
>> +if (WTF_CPU_ARM OR WTF_CPU_ARM64)
> 
> The WTF_CPU_ARM64 is defined based on the `uname -m`. The kernel still could
be a ARM64 but running a ARM 32bits basesystem.

I think this is the wrong approach.  I think that if you’re cross compiling for
32-bit ARM, WTF_CPU_ARM64 shouldn’t be defined.  Is there a reason that this
cannot be?