[webkit-reviews] review granted: [Bug 216507] Element should not set an attribute inside its constructor : [Attachment 408780] Fixed the media tests and addresed Darin's review comments

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 216507: Element should not set an attribute inside its constructor
https://bugs.webkit.org/show_bug.cgi?id=216507

Attachment 408780: Fixed the media tests and addresed Darin's review comments

https://bugs.webkit.org/attachment.cgi?id=408780&action=review




--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 408780
  --> https://bugs.webkit.org/attachment.cgi?id=408780
Fixed the media tests and addresed Darin's review comments

View in context: https://bugs.webkit.org/attachment.cgi?id=408780&action=review

> Source/WebCore/ChangeLog:83
> +2020-09-14  Ryosuke Niwa  <rniwa at webkit.org>
> +
> +	   Element should not set an attribute inside its constructor
> +	   https://bugs.webkit.org/show_bug.cgi?id=216507
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Moved the code to add attributes from element constructors to
respective ::create functions
> +	   since setting attributes could run code in parseAttribute some of
which may try to store
> +	   "this" in Ref / RefPtr, which would not be safe before adoptRef is
called.

Nit - duplicated ChangeLog entry.