[webkit-reviews] review denied: [Bug 216509] Remove testRunner.setAllowsAnySSLCertificate : [Attachment 408769] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 216509: Remove testRunner.setAllowsAnySSLCertificate
https://bugs.webkit.org/show_bug.cgi?id=216509

Attachment 408769: Patch

https://bugs.webkit.org/attachment.cgi?id=408769&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 408769
  --> https://bugs.webkit.org/attachment.cgi?id=408769
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408769&action=review

> Source/WebKit/ChangeLog:8
> +	   It used to be our only way to test TLS failures, but now that we
have TCPServer and HTTPServer used in many tests with TLS, it is unnecessary.

Aren't TCPServer and HTTPServer only for API tests? Moving test from layout
tests to API is super undesirable, because the latter are unscalable and
difficult to work with.

Also, in this patch you are just invalidating a lot of tests without
replacement.