[webkit-reviews] review granted: [Bug 216448] [Apple Win] Migrate from FontPlatformDataWin.cpp to FontPlatformDataCoreText.cpp : [Attachment 408744] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 216448: [Apple Win] Migrate from FontPlatformDataWin.cpp to
FontPlatformDataCoreText.cpp
https://bugs.webkit.org/show_bug.cgi?id=216448

Attachment 408744: Patch

https://bugs.webkit.org/attachment.cgi?id=408744&action=review




--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 408744
  --> https://bugs.webkit.org/attachment.cgi?id=408744
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408744&action=review

> Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp:117
> +    auto bufferData = buffer.createCFData();
> +    result->fontDescriptor =
adoptCF(CTFontManagerCreateFontDescriptorFromData(bufferData.get()));

Reads better without a local variable, I think.