[webkit-reviews] review granted: [Bug 216502] [LFC][FFC] Block box flex items establish block formatting contexts : [Attachment 408760] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 14 16:47:05 PDT 2020

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 216502: [LFC][FFC] Block box flex items establish block formatting contexts

Attachment 408760: Patch


--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 408760
  --> https://bugs.webkit.org/attachment.cgi?id=408760

View in context: https://bugs.webkit.org/attachment.cgi?id=408760&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:108
>      bool isBlockLevelBox() const;
> +    bool isBlockBox() const;

I think a comment is justified to explain the different between BlockLevelBox
and BlockBox

More information about the webkit-reviews mailing list