[webkit-reviews] review granted: [Bug 216485] Remove bogus asserts in FTLLower that assume programs are compiled with sensible speculations : [Attachment 408731] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 14 11:52:11 PDT 2020


Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 216485: Remove bogus asserts in FTLLower that assume programs are compiled
with sensible speculations
https://bugs.webkit.org/show_bug.cgi?id=216485

Attachment 408731: patch

https://bugs.webkit.org/attachment.cgi?id=408731&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 408731
  --> https://bugs.webkit.org/attachment.cgi?id=408731
patch

r=me. I'm a little sad that this may mean we are allowing a "new" OSR exit loop
but I guess we should solve that with a fuzzing flag to try to detect it.


More information about the webkit-reviews mailing list