[webkit-reviews] review granted: [Bug 216486] Web Inspector: REGRESSION(r266885): dyld: Symbol not found: __ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6ObjectENS1_13DumbPtrTraitsIS4_EEEEb : [Attachment 408729] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 216486: Web Inspector: REGRESSION(r266885): dyld: Symbol not found:
__ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6Ob
jectENS1_13DumbPtrTraitsIS4_EEEEb
https://bugs.webkit.org/show_bug.cgi?id=216486

Attachment 408729: Patch

https://bugs.webkit.org/attachment.cgi?id=408729&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 408729
  --> https://bugs.webkit.org/attachment.cgi?id=408729
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408729&action=review

rs=me

> Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp:201
> +    sendResponse(requestId, result.releaseNonNull(), false);

Should it send the `bool` passed into this function, even though it is
"unused"?