[webkit-reviews] review granted: [Bug 210077] [css-flexbox] Indefinite flex-basis percentage should cause height to be ignored : [Attachment 408701] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 210077: [css-flexbox] Indefinite flex-basis percentage should cause height
to be ignored
https://bugs.webkit.org/show_bug.cgi?id=210077

Attachment 408701: Patch

https://bugs.webkit.org/attachment.cgi?id=408701&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 408701
  --> https://bugs.webkit.org/attachment.cgi?id=408701
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408701&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:851
> +	   const auto& flexBasis = flexBasisForChild(child);

I don’t think const auto& is a good type to use here. Just "auto" would be fine
or "Length".