[webkit-reviews] review granted: [Bug 216371] Some WebAudio tests give different output on different machines : [Attachment 408710] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 14 09:20:48 PDT 2020


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 216371: Some WebAudio tests give different output on different machines
https://bugs.webkit.org/show_bug.cgi?id=216371

Attachment 408710: Patch

https://bugs.webkit.org/attachment.cgi?id=408710&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 408710
  --> https://bugs.webkit.org/attachment.cgi?id=408710
Patch

For some reason I don't understand, I think this is better than bundle SPI.
I think it would be even better to modify the test to have different output
(just PASS/FAIL instead of printing audio sample rates) but this is fine too.


More information about the webkit-reviews mailing list