[webkit-reviews] review granted: [Bug 216415] End of media capture should not be reported before 3 seconds of the start of capture : [Attachment 408684] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 14 08:39:41 PDT 2020
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 216415: End of media capture should not be reported before 3 seconds of the
start of capture
https://bugs.webkit.org/show_bug.cgi?id=216415
Attachment 408684: Patch
https://bugs.webkit.org/attachment.cgi?id=408684&action=review
--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 408684
--> https://bugs.webkit.org/attachment.cgi?id=408684
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=408684&action=review
> Source/WebKit/ChangeLog:8
> + Add support for delaying of end of capture.
We're not delaying the end of capture, just the state transition. Also, I think
it would be helpful to state why this is being changed.
Maybe just: A capture indicator should be visible to the user for at least
three seconds.
> Source/WebKit/ChangeLog:9
> + A timer is scheduled when transitioning from no capture to capture.
s/transitioning from no capture to capture/transitioning from capture to no
capture/
> Source/WebKit/UIProcess/API/C/WKPage.cpp:3004
> +void WKPageSetMediaCaptureReportingDelayForTesting(WKPageRef page, double
delay)
> +{
> + toImpl(page)->setMediaCaptureReportingDelay(Seconds(delay));
> +}
It seems a shame to add new C API
> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:330
> + at property (nonatomic, setter=_setMediaCaptureReportingDelayForTesting:)
double _mediaCaptureReportingDelayForTesting
WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
Should this go in WKWebViewPrivateForTesting.h instead?
> Source/WebKit/UIProcess/WebPageProxy.cpp:9073
> + bool isReportingCapture = m_reportedMediaCaptureState &
MediaProducer::MediaCaptureMask;
`haveReportedCapture` might be better.
More information about the webkit-reviews
mailing list