[webkit-reviews] review granted: [Bug 216148] [WebIDL] Replace 'serializable' with '[Default] object toJSON()' : [Attachment 408679] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 216148: [WebIDL] Replace 'serializable' with '[Default] object toJSON()'
https://bugs.webkit.org/show_bug.cgi?id=216148

Attachment 408679: Patch

https://bugs.webkit.org/attachment.cgi?id=408679&action=review




--- Comment #12 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 408679
  --> https://bugs.webkit.org/attachment.cgi?id=408679
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408679&action=review

r=me

> Source/WebCore/ChangeLog:13
> +	   result. Rather, all attributes that quality as have a 'JSON type'
are included

"attributes that quality as have a 'JSON type'" isn't quite right, maybe
"attributes that qualify have a 'JSON type'" or "attributes that have a 'JSON
type'"