[webkit-reviews] review granted: [Bug 216452] Add a key to the text manipulation userInfo dictionary indicating whether the translated item is on-screen : [Attachment 408631] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 216452: Add a key to the text manipulation userInfo dictionary indicating
whether the translated item is on-screen
https://bugs.webkit.org/show_bug.cgi?id=216452

Attachment 408631: Patch

https://bugs.webkit.org/attachment.cgi?id=408631&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 408631
  --> https://bugs.webkit.org/attachment.cgi?id=408631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408631&action=review

> Source/WebCore/editing/TextManipulationController.cpp:300
> +	   if (auto frame = makeRefPtr(node->document().frame()); frame->view()
&& element->renderer()) {

This doesn’t null check the frame. I think you want:

    ... frame()); frame && frame->view() && ...