[webkit-reviews] review denied: [Bug 215974] Wrong error message of the spread. : [Attachment 408597] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 12 15:23:15 PDT 2020

Darin Adler <darin at apple.com> has denied HyeockJin Kim <kherootz at gmail.com>'s
request for review:
Bug 215974: Wrong error message of the spread.

Attachment 408597: Patch


--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 408597
  --> https://bugs.webkit.org/attachment.cgi?id=408597

View in context: https://bugs.webkit.org/attachment.cgi?id=408597&action=review

>> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:1577
>> +	    if (UNLIKELY(scope.exception())) {
> We can't override an exception as it won't necessarily be an unhelpful
"undefined is not a function" one; it could be a userland-thrown error.
> Instead, we should fix `iterationFunction`, which is defined in
> While we do that, we need to make sure Symbol.iterator is looked up only

So it seems we need multiple tests to show our correct handling of these
different cases.

More information about the webkit-reviews mailing list