[webkit-reviews] review granted: [Bug 216435] Clean up LazyLoadImageObserver : [Attachment 408594] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 216435: Clean up LazyLoadImageObserver
https://bugs.webkit.org/show_bug.cgi?id=216435

Attachment 408594: Patch

https://bugs.webkit.org/attachment.cgi?id=408594&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 408594
  --> https://bugs.webkit.org/attachment.cgi?id=408594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408594&action=review

> Source/WebCore/html/LazyLoadImageObserver.h:46
> +    RefPtr<IntersectionObserver> m_lazyLoadImageIntersectionObserver;

You made this name longer, but I might have gone the opposite direction. Given
that this is the intersection observer in the class LazyLoadImageObserver,
obviously it’s the one for lazily loading image, so I would leave the words
"lazy", "load", and "image" out of the name. I might even just call it
m_observer, given the narrow context of being the only data member of this
particular class. A longer name isn’t really helpful to understand what this is
for.