[webkit-reviews] review granted: [Bug 216396] [webkitcorepy] Disable AutoInstaller with environment variable : [Attachment 408559] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 216396: [webkitcorepy] Disable AutoInstaller with environment variable
https://bugs.webkit.org/show_bug.cgi?id=216396

Attachment 408559: Patch

https://bugs.webkit.org/attachment.cgi?id=408559&action=review




--- Comment #7 from dewei_zhu at apple.com ---
Comment on attachment 408559
  --> https://bugs.webkit.org/attachment.cgi?id=408559
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408559&action=review

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:326
> +	   if os.environ.get(cls.DISABLE_ENV_VAR) not in ['0', 'FALSE',
'false', 'NO', 'no', None]:

Should we also consider to add 'No' and 'False' which seem quite common as
well?