[webkit-reviews] review granted: [Bug 216374] [Repaint] RenderLayerModelObject::styleWillChange may issue redundant repaint : [Attachment 408479] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 10 14:57:53 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 216374: [Repaint] RenderLayerModelObject::styleWillChange may issue
redundant repaint
https://bugs.webkit.org/show_bug.cgi?id=216374

Attachment 408479: Patch

https://bugs.webkit.org/attachment.cgi?id=408479&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 408479
  --> https://bugs.webkit.org/attachment.cgi?id=408479
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408479&action=review

> Source/WebCore/rendering/RenderElement.cpp:401
> +		   auto layerMayGetDestroyed = oldStyle.position() !=
newStyle.position() || oldStyle.usedZIndex() != newStyle.usedZIndex() ||
oldStyle.clip() != newStyle.clip() || oldStyle.hasClip() != newStyle.hasClip()
> +		       || oldStyle.hasAutoUsedZIndex() !=
newStyle.hasAutoUsedZIndex() || oldStyle.opacity() != newStyle.opacity() ||
oldStyle.transform() != newStyle.transform() || oldStyle.filter() !=
newStyle.filter();

I prefer the more wrapped version but ¯\_(ツ)_/¯


More information about the webkit-reviews mailing list