[webkit-reviews] review granted: [Bug 216377] Disable hardware JPEG decoding on x86 Mac : [Attachment 408472] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 10 13:42:31 PDT 2020


Geoffrey Garen <ggaren at apple.com> has granted Ben Nham <nham at apple.com>'s
request for review:
Bug 216377: Disable hardware JPEG decoding on x86 Mac
https://bugs.webkit.org/show_bug.cgi?id=216377

Attachment 408472: Patch

https://bugs.webkit.org/attachment.cgi?id=408472&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 408472
  --> https://bugs.webkit.org/attachment.cgi?id=408472
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408472&action=review

r=me

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:341
> +    if (PAL::isMediaToolboxFrameworkAvailable() &&
PAL::canLoad_MediaToolbox_FigPhotoDecompressionSetHardwareCutoff())

If we just need to know whether the framework is available, isn't weak linking
the more efficient option?


More information about the webkit-reviews mailing list