[webkit-reviews] review granted: [Bug 216373] Followup to Bug 215027: address comments to improve APP_BOUND_DOMAINS macro use : [Attachment 408465] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 10 12:40:42 PDT 2020


Darin Adler <darin at apple.com> has granted katherine_cheney at apple.com's request
for review:
Bug 216373: Followup to Bug 215027: address comments to improve
APP_BOUND_DOMAINS macro use
https://bugs.webkit.org/show_bug.cgi?id=216373

Attachment 408465: Patch

https://bugs.webkit.org/attachment.cgi?id=408465&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 408465
  --> https://bugs.webkit.org/attachment.cgi?id=408465
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408465&action=review

> LayoutTests/platform/wk2/TestExpectations:732
> +# App Bound Domains is for iOS only, so we should skip
> +# them here and enable them in the iOS platform specific file.
> +http/tests/resourceLoadStatistics/exemptDomains/ [ Skip ]

I suggest putting this into TestExpectations, rather than
platform/wk2/TestExpectations. Will that work?


More information about the webkit-reviews mailing list