[webkit-reviews] review granted: [Bug 216371] Some WebAudio tests give different output on different machines : [Attachment 408453] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 216371: Some WebAudio tests give different output on different machines
https://bugs.webkit.org/show_bug.cgi?id=216371

Attachment 408453: Patch

https://bugs.webkit.org/attachment.cgi?id=408453&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 408453
  --> https://bugs.webkit.org/attachment.cgi?id=408453
Patch

I think we should make a WKWebViewConfigurationPrivateForTesting.h like we have
WKWebViewPrivateForTesting.h, add an override there, then copy it to an
Optional on WebPageCreationParameters, then in the WebPage constructor if it's
not nullopt we set it globally in that process.  When we process swap, a new
WebPageCreationParameters is already sent to the new process.  It's not
perfect, but it's good enough for test-only SPI.
If you really think that's not a good direction and would prefer increasing our
dependence on the bundle, r=me