[webkit-reviews] review granted: [Bug 216308] REGRESSION (r260360): Ionic modal dialog doesn't animate correctly when dragged and released : [Attachment 408446] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 10 10:06:39 PDT 2020
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 216308: REGRESSION (r260360): Ionic modal dialog doesn't animate correctly
when dragged and released
https://bugs.webkit.org/show_bug.cgi?id=216308
Attachment 408446: Patch
https://bugs.webkit.org/attachment.cgi?id=408446&action=review
--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 408446
--> https://bugs.webkit.org/attachment.cgi?id=408446
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=408446&action=review
> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1032
> + if (anim->playbackRate() != 1 || !anim->directionIsForwards())
> return false;
Why don't we just adjust the timings given to CA so we can still accelerate
these?
More information about the webkit-reviews
mailing list