[webkit-reviews] review granted: [Bug 216362] Upstream some additional feature defines : [Attachment 408438] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 216362: Upstream some additional feature defines
https://bugs.webkit.org/show_bug.cgi?id=216362

Attachment 408438: Patch

https://bugs.webkit.org/attachment.cgi?id=408438&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 408438
  --> https://bugs.webkit.org/attachment.cgi?id=408438
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408438&action=review

> Source/WTF/wtf/PlatformHave.h:760
> +#define HAVE_SESSION_CLEANUP 1

This name seems too generic. What API is it wrapping?

> Source/WTF/wtf/PlatformHave.h:772
> +#define HAVE_QUICKBOARD_COLLECTION_VIEWS 1

Does Quickboard (whatever that is) have a prefix (NS,UI, etc.) that it uses?