[webkit-reviews] review granted: [Bug 216333] [webkitscmpy] Add tags, branches queries on local repositories : [Attachment 408384] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 216333: [webkitscmpy] Add tags, branches queries on local repositories
https://bugs.webkit.org/show_bug.cgi?id=216333

Attachment 408384: Patch

https://bugs.webkit.org/attachment.cgi?id=408384&action=review




--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 408384
  --> https://bugs.webkit.org/attachment.cgi?id=408384
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408384&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:60
> +	   with mocks.local.Git(self.path, branches=('branch-1', 'branch-2')):
> +	       self.assertEqual(
> +		   local.Git(self.path).branches,
> +		   ['main', 'branch-1', 'branch-2'],
> +	       )

Maybe add `remotes/origin/HEAD -> origin/main`to the test case and expect it to
be excluded?