[webkit-reviews] review granted: [Bug 216227] Proxy's "ownKeys" trap result should not be sorted : [Attachment 408139] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 9 14:32:21 PDT 2020
Yusuke Suzuki <ysuzuki at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 216227: Proxy's "ownKeys" trap result should not be sorted
https://bugs.webkit.org/show_bug.cgi?id=216227
Attachment 408139: Patch
https://bugs.webkit.org/attachment.cgi?id=408139&action=review
--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 408139
--> https://bugs.webkit.org/attachment.cgi?id=408139
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=408139&action=review
r=me
> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:369
> + ASSERT(propertyName.isSymbol() ? !propertyName.isPrivateName() :
true);
Let's use `ASSERT(!propertyName.isPrivateName())`.
More information about the webkit-reviews
mailing list