[webkit-reviews] review granted: [Bug 216323] kill-old-processes: Avoid calling kill command with empty string : [Attachment 408362] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 9 14:06:23 PDT 2020


Darin Adler <darin at apple.com> has granted Lauro Moura <lmoura at igalia.com>'s
request for review:
Bug 216323: kill-old-processes: Avoid calling kill command with empty string
https://bugs.webkit.org/show_bug.cgi?id=216323

Attachment 408362: Patch

https://bugs.webkit.org/attachment.cgi?id=408362&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 408362
  --> https://bugs.webkit.org/attachment.cgi?id=408362
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408362&action=review

> Tools/ChangeLog:3
> +	   kill-old-processes: Avoid calling kill command with empty string

This is a platform-specific bug and fix. On BSD systems like macOS, xargs
already doesn’t do this. But on platforms with GNU xargs this "-r" option is
needed.


More information about the webkit-reviews mailing list