[webkit-reviews] review granted: [Bug 216322] [WebIDL] Stop automatically applying the ImplementedBy extended attribute to all partial interfaces/dictionaries : [Attachment 408363] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 216322: [WebIDL] Stop automatically applying the ImplementedBy extended
attribute to all partial interfaces/dictionaries
https://bugs.webkit.org/show_bug.cgi?id=216322

Attachment 408363: Patch

https://bugs.webkit.org/attachment.cgi?id=408363&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 408363
  --> https://bugs.webkit.org/attachment.cgi?id=408363
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408363&action=review

> Source/WebCore/ChangeLog:13
> +	   behavior mush opt in, using the extended attribute "ImplementedBy",
which is what the code

typo: "must"

> Source/WebCore/ChangeLog:25
> +	   Remove special casing of partial interfaces / dictionaries
automatically getting "ImplementedBy"
> +	   applied to all members. Maintain the behavior that "ImplementedBy"
should not be used when
> +	   an attribute has been marked as "Reflect".

When we say "should not be used" we mean "should be silently ignored"? Is that
right? That seems to be new. It’s one thing to not implicitly add ImplementedBy
when Reflect is specified. Not sure it’s right to ignore it rather than
emitting an error message.