[webkit-reviews] review granted: [Bug 216310] WebGL2RenderingContext should use Graphics Context types : [Attachment 408327] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 9 11:28:24 PDT 2020

Kenneth Russell <kbr at google.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 216310: WebGL2RenderingContext should use Graphics Context types

Attachment 408327: Patch


--- Comment #2 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 408327
  --> https://bugs.webkit.org/attachment.cgi?id=408327

View in context: https://bugs.webkit.org/attachment.cgi?id=408327&action=review

Thanks for fixing this build! r+ with one comment.

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:2109
> +	   return GraphicsContextGL::WAIT_FAILED_WIN;

We could consider naming this WAIT_FAILED_WEBGL in all cases.

More information about the webkit-reviews mailing list