[webkit-reviews] review granted: [Bug 216195] Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess : [Attachment 408344] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 216195: Move lazy DisplayLink tear down logic from the WebProcess to the
UIProcess
https://bugs.webkit.org/show_bug.cgi?id=216195

Attachment 408344: Patch

https://bugs.webkit.org/attachment.cgi?id=408344&action=review




--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 408344
  --> https://bugs.webkit.org/attachment.cgi?id=408344
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408344&action=review

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:79
> +    LockHolder locker(m_observersLock);

Do we need to hold this lock across the call to CVDisplayLinkStart() below?

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:135
> +    if (displayLink->m_observers.isEmpty()) {
> +	   if (++(displayLink->m_fireCountWithoutObservers) >=
maxFireCountWithoutObservers)
> +	       CVDisplayLinkStop(displayLink->m_displayLink);
> +	   return kCVReturnSuccess;
> +    }
> +    displayLink->m_fireCountWithoutObservers = 0;
> +
>      for (auto& connection : displayLink->m_observers.keys()) {

Lots of displayLink-> here. Would be cleaner as a member function on
DisplayLink.