[webkit-reviews] review granted: [Bug 215853] REGRESSION (r264856): updating easing on accelerated animation results in incorrect playback : [Attachment 408330] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 9 09:53:28 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 215853: REGRESSION (r264856): updating easing on accelerated animation
results in incorrect playback
https://bugs.webkit.org/show_bug.cgi?id=215853

Attachment 408330: Patch

https://bugs.webkit.org/attachment.cgi?id=408330&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 408330
  --> https://bugs.webkit.org/attachment.cgi?id=408330
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408330&action=review

Maybe also add a test for easing -> steps change.

>
LayoutTests/webanimations/accelerated-animation-easing-update-after-pause.html:
64
> +    await UIHelper.ensurePresentationUpdate();
> +    await UIHelper.renderingUpdate();

Are both of these necessary?


More information about the webkit-reviews mailing list