[webkit-reviews] review granted: [Bug 216301] Import selection web platform tests : [Attachment 408300] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 8 23:03:08 PDT 2020

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 216301: Import selection web platform tests

Attachment 408300: Patch


--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 408300
  --> https://bugs.webkit.org/attachment.cgi?id=408300

Skipping timing out tests is always preferable than running them.
It is also better to import all tests in a folder: we can fix them
progressively and we do not have to spend the time to rediscover they are
timing out on each reimport.

Looking at some of these tests, they end up with more than 5000 subtests...
Alex, please verify these tests pass in debug.

More information about the webkit-reviews mailing list